Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement uninstall. Also modify the output of list on Mac and deprecate Installation.path in favor of Installation.root_path #171

Merged
merged 6 commits into from
Oct 26, 2017
Merged

Implement uninstall. Also modify the output of list on Mac and deprecate Installation.path in favor of Installation.root_path #171

merged 6 commits into from
Oct 26, 2017

Conversation

lacostej
Copy link
Member

@lacostej lacostej commented Oct 25, 2017 •
edited
Loading

@niezbop could you please test this on Windows? :)

niezbop
niezbop approved these changes Oct 26, 2017
View reviewed changes
Copy link
Member

@niezbop niezbop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Windows, it works really well. Maybe add a bit of verbose regarding the uninstall not deleting files right away

@lacostej lacostej merged commit 5b03e23 into DragonBox:master Oct 26, 2017
@lacostej lacostej deleted the feature/uninstall branch October 26, 2017 09:29
@lacostej lacostej mentioned this pull request Oct 31, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niezbop niezbop niezbop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lacostej @niezbop