u3d/prettify: Fix UnityEngine.Debug.LogXXXFormat not being caught #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niezbop
force-pushed
the
fix/prettify_catch_logformat
branch
2 times, most recently
from
512513a to
9608988
Compare
lacostej
approved these changes
Mar 26, 2018
niezbop
force-pushed
the
fix/prettify_catch_logformat
branch
from
9608988 to
cafa092
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
bundle exec rspecto make sure that my PR didn't break any testbundle exec rubocopto make sure that my PR is inline with our code stylePull Request Description
Fixes #269
This simply makes it so that the prettifier rules for logging (normal, assertion, warning and error) match format logs as well so that they appear in the prettifier output (and consequently in the
u3d runoutput as well). I have extended the pattern for matching a logging rule so thatDebug.LogXXXFormatis treated the same way asDebug.LogXXX, making it easier to read logs.