Rubocop / Improve code style

lib/u3d/commands.rb

@@ -42,7 +42,7 @@ def list_installed(options: {})
           return
         end
         # version -> installations
-        arraym = list.map{|a| [a.version, a]}
+        arraym = list.map { |a| [a.version, a] }
         map = Hash[*arraym.flatten]
         # sorted versions
         vcomparators = map.keys.map { |k| UnityVersionComparator.new(k) }
@@ -218,7 +218,7 @@ def credentials_actions
         %w(add remove check)
       end
 
-      def credentials(args: [], options: {})
+      def credentials(args: [], _options: {})
         action = args[0]
         raise "Please specify an action to perform, one of #{credentials_actions.join(',')}" unless action
         raise "Unknown action '#{action}'. Use one of #{credentials_actions.join(',')}" unless credentials_actions.include? action

lib/u3d/unity_runner.rb

@@ -54,7 +54,7 @@ def run(installation, args, raw_logs: false)
       end
 
       # Wait for tail_thread setup to be complete
-      sleep 0.5 while tail_thread.status!='sleep'
+      sleep 0.5 while tail_thread.status != 'sleep'
       tail_thread.run
 
       begin

lib/u3d/unity_versions.rb

@@ -166,7 +166,7 @@ def list_available
             if response.kind_of? Net::HTTPSuccess
               capt = response.body.match(LINUX_DOWNLOAD_RECENT_FILE)
               if capt && capt[1] && capt[2]
-                versions[capt[2].gsub(/x/, '')] = capt[1]
+                versions[capt[2].delete('x')] = capt[1]
               else
                 UI.error("Could not retrieve a fitting file from #{url}")
               end

lib/u3d_core/command_executor.rb

@@ -120,7 +120,8 @@ def has_admin_privileges?
           credentials = U3dCore::Credentials.new(user: ENV['USER'])
           begin
             result = system("sudo -k && echo #{credentials.password.shellescape} | sudo -S /usr/bin/whoami",
-              out: File::NULL, err: File::NULL)
+              out: File::NULL,
+              err: File::NULL)
           rescue
             result = false
           end

spec/spec_helper.rb

@@ -49,4 +49,4 @@ def with_env_values(hash)
     ENV.delete(k) unless old_vals.include?(k)
     ENV[k] = old_vals[k]
   end
-end
+end

spec/u3d/log_analyzer_spec.rb

@@ -29,15 +29,19 @@ class CustomExpectations
   def phase_active(phases)
     expect(phases).to have_key('TEST_ACTIVE')
   end
+
   def phase_not_active(phases)
     expect(phases).not_to have_key('TEST_NOT_ACTIVE')
   end
+
   def silent_phase_use(phases)
     expect(phases).to have_key('TEST')
   end
+
   def silent_phase_rules(phases)
     expect(phases['TEST']['rules']).to be_empty
   end
+
   def phase_start_pattern_parsing(phases)
     expect(phases['TEST']['phase_start_pattern']).to eql(/This is a pattern/)
   end
@@ -48,7 +52,7 @@ def phase_start_pattern_parsing(phases)
 describe U3d do
   describe U3d::LogAnalyzer do
     describe '.load_rules custom' do
-      data =  JSON.parse(File.read(rules_data_file))
+      data = JSON.parse(File.read(rules_data_file))
       data.each do |key, test_cases|
         it test_cases['message'] do
           file = double('file')
@@ -63,7 +67,7 @@ def phase_start_pattern_parsing(phases)
       it "loads defaults rules without problem" do
         gen, phases = U3d::LogAnalyzer.new.load_rules
         expect(gen.keys.count).to be > 5
-        expect(phases.keys).to eq ['JENKINS','INIT','COMPILER','ASSET']
+        expect(phases.keys).to eq %w(JENKINS INIT COMPILER ASSET)
       end
 
       it "parses a simple file" do