Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various gem updates to solve security vulnerabilities in development tools #419

Merged
merged 5 commits into from
May 16, 2022

Conversation

lacostej
Copy link
Member

Pull Request Description

Hopefully addressing most of them at once.

@lacostej lacostej requested a review from niezbop May 16, 2022 13:33
Copy link
Member

@niezbop niezbop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to say! Just one non-critical question

@@ -35,11 +35,15 @@ Gem::Specification.new do |spec|
spec.add_dependency 'rubyzip', '>= 1.0.0' # Installation of .zip files
spec.add_dependency 'security', '= 0.1.3' # macOS Keychain manager, a dead project, no updates expected
# Development only
spec.add_development_dependency "activesupport", ">= 5.2.4.3" # force secure transitive dep
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the sake of curiosity, what warranted moving dependencies around in the file, and adding other?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lacostej lacostej merged commit 3189da9 into master May 16, 2022
@lacostej lacostej deleted the fix/security_vulnerabilities branch May 16, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants