Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tech] rubocop cleanups #46

Merged
merged 28 commits into from
Aug 8, 2017
Merged

[tech] rubocop cleanups #46

merged 28 commits into from
Aug 8, 2017

Conversation

lacostej
Copy link
Member

@lacostej lacostej commented Aug 8, 2017

Not yet fully tested.

@lacostej lacostej requested a review from niezbop August 8, 2017 12:23
lacostej added 28 commits August 8, 2017 16:14
@lacostej
Rubocop rules to reduce thresholds
ceb6ee1
@lacostej
Rubocop: disable eval in Gemfile
05c8d90
@lacostej
Cleanup: extract method in commands
390266d
@lacostej
Cleanup: extract method in credentials commands
c81e049
@lacostej
More rubocop cleanups
1c430cc
@lacostej
Rubocop: globals respond_to? -> respond_to_missing?
515df5d
@lacostej
Rubocop: align parameters
2acf030
@lacostej
Rubocop: adjust rules
be66f04
@lacostej
Rubocop: extract method and disable rule
05f1a4b
@lacostej
Cleanup: rubocop
cf4abc4
@lacostej
Cleanup: extract 2 methods into Downloader from Commands to reduce me…
e6c90b2 
…thod complexity
@lacostej
Cleanup / rubocop
9816a30
@lacostej
Rubocop: disable class length on commands_generator
4192156
@lacostej
rubocop: unused param
35ba974
@lacostej
rubocop: regexp
64f2680
@lacostej
rubocop: assignment
c33c726
@lacostej
rubocop: disable 3 metrics for complex log_analyzer class
a85aec8
@lacostej
rubocop: extract method (u3d available linux)
7418b88
@lacostej
rubocop: disable cop on has_admin_privileges?
6a2aa94
@lacostej
rubocop: extract grant_admin_privileges method
d0a3209
@lacostej
rubocop: split method to reduce complexity
48ab69d
@lacostej
rubocop: more cleanups
1119b97
@lacostej
rubocop: rename method
a2c4ea0
@lacostej
rubocop: more cop disabling
bb9ff21
@lacostej
rubocop: adjust code against double negation
68392e8
@lacostej
rubocop: nested if
9ace7bb
@lacostej
Enable rubocop by default
04bb1bf
@lacostej
Rubocop Rakefile cleanup
6d8be32
niezbop
niezbop approved these changes Aug 8, 2017
View reviewed changes
Copy link
Member

@niezbop niezbop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Windows, all the commands are working fine and rspec tests are passing.

@lacostej lacostej merged commit 4a071b0 into DragonBox:master Aug 8, 2017
@lacostej lacostej deleted the cleanups branch August 8, 2017 15:06
@lacostej lacostej changed the title Rubocop cleanups [tech] rubocop cleanups Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niezbop niezbop niezbop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lacostej @niezbop