Add tests for INIParser.create_linux_ini' #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niezbop
requested changes
Aug 27, 2017
spec/u3d/iniparser_spec.rb
Outdated
| @@ -82,5 +82,36 @@ | |||
| end | |||
| end | |||
| end | |||
|
|
|||
| describe '.create_linux_ini', focuss: true do | |||
There was a problem hiding this comment.
Remove focus tag if this is not meant to stay?
spec/u3d/iniparser_spec.rb
Outdated
| it 'does not rewrite the file' do | ||
| path = %r{\/.u3d\/ini_files\/unity-1.2.3f4-linux.ini} | ||
|
|
||
| allow(U3dCore::Helper).to receive(:operating_system) { :linux } |
There was a problem hiding this comment.
You can use shortcut on_linux from the setups
spec/u3d/iniparser_spec.rb
Outdated
|
|
||
| allow(File).to receive(:file?).with(path) { false } | ||
| file = double('file') | ||
| allow(File).to receive(:open).with(path, 'wb') { |&block| block.call(file) } |
There was a problem hiding this comment.
.and_yield file may be more elegant? It would be more consistent with the rest of the test as well
There was a problem hiding this comment.
Ah yes. I was looking for the right way to do that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.