实现Ps/2鼠标驱动 #500
Merged
实现Ps/2鼠标驱动 #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…47742618/DragonOS into patch-serio-device-and-driver
…agonOS into patch-mouse-driver
fslongjin
requested changes
Jan 22, 2024
| self.inner.lock().devices.clone() | ||
| } | ||
|
|
||
| fn add_device(&self, device: Arc<dyn crate::driver::base::device::Device>) { |
There was a problem hiding this comment.
这种带前缀的都改一下，不然将来如果这个Device移动文件位置了，修代码很困难
| } | ||
|
|
||
| fn dev_groups(&self) -> &'static [&'static dyn crate::filesystem::sysfs::AttributeGroup] { | ||
| return &[&SerioDeviceAttrGroup]; |
There was a problem hiding this comment.
默认属性组应该由那个SerioManager之类的东西去负责创建，而不是每个驱动都写自己有这个属性。
| _char: u8, | ||
| _int: u8, | ||
| ) -> Result<(), system_error::SystemError> { | ||
| todo!() |
| ) -> Result<usize, SystemError> { | ||
| let guard = self.inner.lock_irqsave(); | ||
| if offset > 0 && offset + len < guard.buf.len() { | ||
| buf.copy_from_slice(&guard.buf[offset..offset + len]); |
There was a problem hiding this comment.
这个buf我在想能否开大一点，然后通过一个index来记录它目前是正在操作第几位（或者用ringbuffer库）。我担心就是，用户程序读不过来。
fslongjin
requested changes
Jan 23, 2024
fslongjin
approved these changes
Jan 24, 2024
yuyi2439
pushed a commit
to yuyi2439/DragonOS
that referenced
this pull request
Feb 2, 2024
实现Ps/2鼠标驱动
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.