Expose a typesafe way to get global variables #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using [CSharp.lua's method of inserting Lua code](https://github.com/yanghuan/CSharp.lua/wiki/FAQ_en#7how-do-you-call-or-insert-lua-code-in-your-code), we can leverage that to allow access to global variables from C#.
|
It's easier to write using CSharpLua.Template: /// @CSharpLua.Template = "rawget(System.global, {0})"
public static extern T GetGlobal<T>(string key); |
|
I just tested this method, it works when added directly to the source, but not when added as a package (.dll/.xml). This is due to a bug in my fork of CSharpLua, which is unable to parse the documentation .xml file properly: it cannot find the CSharpLua.Template attribute, because you added documentation xml nodes to it (summary, etc). I'll have to fix this bug before I can merge your PR. |
|
Did some more testing, and it turns out I incorrectly assumed it was caused by the documentation. The real cause is the generic type argument (in combination with it being passed to the transpiler as a .dll instead of .cs). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using CSharp.lua's method of inserting Lua code, we can leverage that to allow access to global variables from C#.