Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deploy] Add Kubernetes deployment file #2041

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Conversation

Herklos
Copy link
Member

@Herklos Herklos commented Sep 17, 2022

No description provided.

@Herklos Herklos self-assigned this Sep 17, 2022

---
apiVersion: v1
kind: PersistentVolumeClaim
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restartPolicy: Always
volumes:
- name: octobot-logs
emptyDir: {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does that mean we not save logs for an execution to another ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logs will also be retrieved with the console output of the containers so I don't think we need to store them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The console output has to be as detailed as the logfiles one for kub in this case 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we want to store hundreds of megabytes per bot per day with the DEBUG level.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should not be that much, it's reduced by a lot now. For example right now I have a 1h runing bot with 31Ko logs. It's to be analysed if we need debug logs or not I think in cloud bots

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be easier to have the logs collected in the output of the console even if it means modifying the logs level when we are in the cloud. It will be much simpler rather than going to recover log files if needed

@kaovilai
Copy link

Had just tried to run this.. but I think the IS_CLOUD_ENV is triggering unimplemented behavior.

@Herklos
Copy link
Member Author

Herklos commented Sep 27, 2022

Had just tried to run this.. but I think the IS_CLOUD_ENV is triggering unimplemented behavior.

Hi! Yes we are working on the cloud env, it may not be stable for now.

@Herklos Herklos force-pushed the feature/add-kub-file branch from feb1738 to ed6da95 Compare March 10, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants