Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Perf 63%] System.Collections.CtorFromCollection<String>.Dictionary #2328

Open
performanceautofiler bot opened this issue Oct 16, 2020 · 0 comments
Open

[Perf 63%] System.Collections.CtorFromCollection<String>.Dictionary #2328

performanceautofiler bot opened this issue Oct 16, 2020 · 0 comments
Labels
Baseline Outlier Improvement refs/heads/master Windows 10.0.18362 x86

Comments

@performanceautofiler
Copy link

performanceautofiler bot commented Oct 16, 2020 •
edited
Loading

Run Information

Architecture x86
OS Windows 10.0.18362
Changes diff

Regressions in System.Collections.CtorFromCollection

Benchmark Baseline Test Test/Base Modality Baseline Outlier Baseline ETL Comapre ETL
Dictionary 17.39 μs 6.17 μs 0.35 Bimodal True Trace Trace

Related Issue on x64 ubuntu

[Perf 41%] System.Collections.CtorFromCollection (3)

Related Issue on x64 ubuntu

[Perf 71%] System.Collections.CtorFromCollection.Dictionary

Related Issue on x64 Windows

[Perf 72%] System.Collections.CtorFromCollection.Dictionary

graph
Historical Data in Reporting System

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f netcoreapp5.0 --filter 'System.Collections.CtorFromCollection<String>*'

Histogram

System.Collections.CtorFromCollection.Dictionary(Size: 512)

[ 4689.448 ;  7757.548) | @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
[ 7757.548 ; 10668.413) | 
[10668.413 ; 13579.277) | 
[13579.277 ; 15738.414) | 
[15738.414 ; 19119.237) | @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
This was referenced Oct 19, 2020
Open
Closed
Open
Open
@performanceautofiler performanceautofiler bot mentioned this issue Oct 26, 2020
Closed
This was referenced Nov 9, 2020
Open
Closed
@performanceautofiler performanceautofiler bot mentioned this issue Dec 1, 2020
Open
This was referenced Jan 5, 2021
Closed
Open
DrewScoggins pushed a commit that referenced this issue Apr 5, 2022
@adamsitnik
Add NativeAOT (and CoreRT) support for micro benchmarks (#2328)
6e1585f 
* prefer AppContext.BaseDirectory over typeof(X).Assembly.Location

* GetReferencedAssemblies() is not supported on AOT

* Arrays with non-zero lower bounds are not supported

* BinaryFormatter serialization and deserialization are disabled within this application.

* Dynamic code generation is not supported on this platform.

* disable AddRemoveFromDifferentThreads as it hangs

* disable more serialization benchmarks

* disable Activator.CreateInstance(_assemblyName, _typeName) benchmark as it's not supported

* add NativeAOT and CoreRT support to the python scripts

* bump BDN version

* address code review feedback, don't use the CoreRT name anymore

* add NativeAOT CI leg

* increase build timeout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Baseline Outlier Improvement refs/heads/master Windows 10.0.18362 x86
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants