Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Perf -14%] System.Threading.Tasks.ValueTaskPerfTest.CreateAndAwait_FromYieldingAsyncMethod #2703

Closed
performanceautofiler bot opened this issue Oct 26, 2020 · 0 comments
Closed

[Perf -14%] System.Threading.Tasks.ValueTaskPerfTest.CreateAndAwait_FromYieldingAsyncMethod #2703

performanceautofiler bot opened this issue Oct 26, 2020 · 0 comments
Labels
Baseline Outlier LLVM=false MonoAOT=false MonoInterpreter=false refs/heads/master Regression RunKind=micro_mono ubuntu 18.04 x64

Comments

@performanceautofiler
Copy link

performanceautofiler bot commented Oct 26, 2020 •
edited
Loading

Run Information

Architecture x64
OS ubuntu 18.04
Baseline bdd25a2eb910d87847c0fcc47bfe31b4dc1a576e
Compare b6f791d1984f998384267b8b6683bd02f64747f2

Regressions in System.Threading.Tasks.ValueTaskPerfTest

Benchmark Baseline Test Test/Base Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
CreateAndAwait_FromYieldingAsyncMethod 1.03 μs 1.19 μs 1.16

graph
Historical Data in Reporting System

Repro

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f netcoreapp5.0 --filter 'System.Threading.Tasks.ValueTaskPerfTest*'

Histogram

System.Threading.Tasks.ValueTaskPerfTest.CreateAndAwait_FromYieldingAsyncMethod

[1011.721 ; 1052.747) | @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
[1052.747 ; 1083.892) | @@@@@@@@@@@@@
[1083.892 ; 1119.590) | 
[1119.590 ; 1155.288) | 
[1155.288 ; 1212.803) | @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
@naricc naricc mentioned this issue Nov 2, 2020
Closed
@performanceautofiler performanceautofiler bot mentioned this issue Nov 3, 2020
Open
@naricc naricc closed this as completed Dec 17, 2020
DrewScoggins pushed a commit that referenced this issue Jan 9, 2023
@adamsitnik
[Microbenchmarks] TFMs cleanup + Microsoft.Extensions* update (#2703)
3fc552c 
* use 7.0.0 Microsoft.Extensions* when targeting net7.0, so .NET 6 vs 7 diff shows the actual difference for Extensions benchmarks, fixes dotnet/runtime#77900

* update net461 to net462 as the 7.0.0 version of System* libraries like System.Threading.Channels do not support net461 anymore

* remove net5.0 (it's not supported anymore)

* the test projects don't need to target old monikers, net7.0 is enough
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Baseline Outlier LLVM=false MonoAOT=false MonoInterpreter=false refs/heads/master Regression RunKind=micro_mono ubuntu 18.04 x64
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@naricc