Skip to content

Commit

Permalink
Fix key beams not appearing when delay fade effects are off and a chi…
Browse files Browse the repository at this point in the history
…p object has passed the crit line
  • Loading branch information
ASleepyCat committed Apr 27, 2021
1 parent 1452c99 commit 3a4c72c
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions Main/src/Scoring.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1429,6 +1429,8 @@ bool Scoring::HoldObjectAvailable(uint32 index, bool checkIfPassedCritLine)
auto currentTime = m_playback->GetLastTime();
auto tick = m_ticks[index].front();
auto obj = (HoldObjectState*)tick->object;
if (obj->type != ObjectType::Hold)
return false;
// When a hold passes the crit line and we're eligible to hit the starting tick,
// change the idle hit effect to the crit hit effect
bool withinHoldStartWindow = tick->HasFlag(TickFlags::Start) && m_IsBeingHold(tick) && (!checkIfPassedCritLine || obj->time <= currentTime);
Expand Down

0 comments on commit 3a4c72c

Please sign in to comment.