[Feature] Automatic Song Offset

[ThiefOfSouls]

I was wondering if it would be possible to at least semi-automatic the song offset. I believe I have my input offset set up correctly but still run into songs that may be 5-10ms off. It isn't hard to change the song offset manually but it is a minor annoyance and sometimes I go through the result screen quickly without checking what the offset might need to be.

My initial thoughts was to have a toggle in the settings to automatically update the songs offset after a play based on the median timing though if it is a small enough value (1-2ms) than maybe it shouldn't change it. The other possibility is having a button on the result screen that will adjust the offset for you so that the player can decide if they want to change it.

[Drewol]

#392 might have what you want but I have not yet had the time to review it properly.

[ThiefOfSouls]

From the description of the fork it sounds better than what I was asking for since my idea was just to make it easier to set the offset after playing the song once rather than precomputing it. I might actually look at building the fork to give it a test, thanks for pointing it out to me.

[123jimin]

Before working on that PR, I have considered implementing what you described, but I decided not to as human play could result in a biased offset. Usually people tend to press buttons earlier for high-density button charts.

But still it's a better to give players more options, and two is better than one, so I'll try implementing what you described.