Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scroll speed support and preliminary refactoring for per-note effects #445

Closed
wants to merge 15 commits into from
Closed

Scroll speed support and preliminary refactoring for per-note effects #445

wants to merge 15 commits into from

Conversation

123jimin
Copy link

@123jimin 123jimin commented Apr 3, 2021 •
edited
Loading

This PR plans to implement scroll_speed modifier (how to specify this in ksh is not yet decided), and re-implement stops using it.

  • Read stops as scroll speed mods
  • Implement scroll speed changes (speed >= 0)
  • Implement scroll speed changes (speed < 0)
  • Evaluate performance impact (play a long chart and compare loading time / per-frame execution time)

This PR also includes preliminary refactoring:

  • Separate graph logic for effects
  • Moved more Beatmap-related manipulations inside Beatmap
  • Refactor BeatmapPlayback (no longer assumes that notes are added in a linear order)
  • Reduce usage of raw pointers
  • Remove unsupported binary format
  • Refactor render logic, mostly related to deciding note positions and view matrices

This is to support following features, but does not implement those (separated to future PRs):

  • Per-note custom camera effects
  • KSON camera effect support
  • Bezier graph support

This and future PR will not try to implement bezier lasers and refactor ObjectState (no curved lasers for now).

@123jimin
Fixed never-opened profile page resetting config
59444e3
@123jimin
Refactored how zoom values are stored
5c772b7 
REGRESSIONS:
* Stop effects are not shown (will replace with scroll speeds)
* Binary format support
@123jimin
Simple implementation of reading Stops
5fa81d3
@123jimin
Fixed CI error
11b5a0f
@123jimin
Re-added includes to Math.hpp
36054ec
@123jimin
Fixed another thing CI doesn't like
261b198
@123jimin
Merge remote-tracking branch 'upstream/develop' into 202104-not-usc
02c5286
@123jimin
Refactored BeatmapPlayback
bd0850d 
Preparing for scroll speed implementation
@123jimin
Removed support for binary file format support
a250e53
@123jimin
Moved timing point selection logic to Beatmap, and marked functions t…
5b043d6 
…o replace
@123jimin
Fix crash on automatic offset computation for some charts
be7f070 
REGRESSION:
@123jimin
Implemented scroll_speed
45f24b3 
REGRESSION: measure lines are not visible.
Also, some optimizations should be done to prevent integrating same region over and again for each frame.
@123jimin
Fixes Drewol#348
9d5447c
@123jimin
Improved long note visibility during scroll speed changes
c79d84d
@123jimin
Merge remote-tracking branch 'upstream/develop' into 202104-scroll-speed
0675922
@123jimin 123jimin marked this pull request as ready for review April 10, 2021 14:40
@123jimin
Copy link
Author

While the visual distance computation logic is unoptimized, its performance impact was measured to be negligible.
Some long button behaviors and laser behaviors certainly needs improvements, but I think that this PR can be merged to develop now, and further improvements / implements would be built upon this and made into separate PRs.

@123jimin
Copy link
Author

123jimin commented Oct 4, 2021

Will separate this into two PRs (refactor & scroll-speed)

@123jimin 123jimin closed this Oct 4, 2021
@123jimin 123jimin mentioned this pull request Oct 6, 2021
Merged
@123jimin 123jimin deleted the 202104-scroll-speed branch April 3, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@123jimin