Bumped up to C++17 and enabled /MP for all projects #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
123jimin
commented
Apr 12, 2021
| @@ -14,9 +14,7 @@ class Buffer : public Vector<uint8>, Unique | |||
| Buffer(Buffer&& rhs); | |||
| Buffer& operator=(Buffer&& rhs); | |||
| // Creates a new buffer from a string, without the terminating null character | |||
| Buffer(const char* string); | |||
| // Creates a new buffer with an initial size | |||
| Buffer(size_t initialSize); | |||
There was a problem hiding this comment.
msvc complains that this is indistinguishable from the constructor from std::vector. Since they do the same job (sans initialization for this Buffer::Buffer(size_t)), I just removed this constructor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compile time on a 6-core 12-thread CPU (very non-scientific; ran each twice in a row and used later value to reduce deviations caused by file caching):
Sadly, CI doesn't seem to be affected by this.
Forgot to add /MP for test projects but it doesn't matter a lot.