Add more info to .csproj file to improve NuGet packaging
#23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyhaberman
approved these changes
Aug 1, 2023
| @@ -2,7 +2,12 @@ | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFramework>netstandard2.0</TargetFramework> | |||
| <PackageId>DripDotNetSDK</PackageId> | |||
There was a problem hiding this comment.
Do we need to keep this name? Isn't this a .NET and SDK thing by definition?
What about just "Drip"?
There was a problem hiding this comment.
Yep, you're correct.
However, according to this stack overflow answer (with no upvotes, to be fair), you cannot rename a package: https://stackoverflow.com/a/73882184/3991562
Therefore, unless there is extreme pushback either from within Drip or from our customers, I don't plan on changing this, since we've already got three packages out on NuGet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of this stuff is stuff I used to package and upload the first version of the package here: https://www.nuget.org/packages/DripDotNetSDK/
I then noticed that one of the two other versions of this package (https://www.nuget.org/packages/Leadpages.Drip.DripDotNet) has tags to improve discoverability, so I added those in addition to the things I used to upload the package to NuGet.