fix: segfault on arm due to unaligned atomics #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrmagicE
reviewed
Dec 4, 2020
client.go
Outdated
| @@ -94,6 +94,12 @@ type Client interface { | |||
|
|
|||
| // Client represents a MQTT client and implements the Client interface | |||
| type client struct { | |||
| // These two int64s must be at th etop to guarantee they are 64bit aligned | |||
There was a problem hiding this comment.
please fix the typo: 'th etop to'.
This fixes the following segfault:
runtime/internal/atomic.goStore64(0x2487864, 0x5fc9a110, 0x0)
/home/konrad/opt/go/src/runtime/internal/atomic/atomic_arm.go:144 +0x1c
github.com/DrmagicE/gmqtt.(*client).setDisconnectedAt(0x2487800, 0x184d7eef, 0xbfea8
The atomics must be 64bit aligned on 32bit architectures because
otherwise an attempt to store results in segfault.
See: https://golang.org/pkg/sync/atomic/#pkg-note-BUG
bergotorino
force-pushed
the
fix/segfault-on-arm
branch
from
cc83930
to
d7794b5
Compare
Codecov Report
@@ Coverage Diff @@
## master #31 +/- ##
==========================================
- Coverage 70.33% 70.12% -0.22%
==========================================
Files 26 26
Lines 2353 2353
==========================================
- Hits 1655 1650 -5
- Misses 540 546 +6
+ Partials 158 157 -1
Continue to review full report at Codecov.
|
|
Thanks for your PR.😄 merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following segfault:
runtime/internal/atomic.goStore64(0x2487864, 0x5fc9a110, 0x0)
/home/konrad/opt/go/src/runtime/internal/atomic/atomic_arm.go:144 +0x1c
github.com/DrmagicE/gmqtt.(*client).setDisconnectedAt(0x2487800, 0x184d7eef, 0xbfea8
The atomics must be 64bit aligned on 32bit architectures because
otherwise the attempt to store a value results in segfault.
See: https://golang.org/pkg/sync/atomic/#pkg-note-BUG