Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSS Color Module Level 3 Extended Keyword Functions to CBA #1

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

lambdatiger
Copy link

@lambdatiger lambdatiger commented Sep 27, 2024

This PR references these W3c color keywords:
https://www.w3.org/TR/css-color-3/#svg-color
When merged this pull request will:

  • Add a hashmap CBA_common_cssColorNames
  • Add a function to convert from color keyword to

Feedback Requested:

  • Should the cache be in preStart? I know ACE does this, but it's currently just a config lookup that NEEDS to be there
  • Do we want the procedural textures to be argb rather than rgb, I know certain times it's useful to have one over the other when texturing things.

@Drofseh
Copy link
Owner

Drofseh commented Sep 27, 2024

Can you edit the PR to point to my colour-conversion branch instead of the main branch?

Also QGVAR(cssColorNames) will expande to CBA_common_cssColorNames not CBA_main_cssColorNames

@lambdatiger
Copy link
Author

lambdatiger commented Sep 27, 2024

Yeah, thought I'd PR'd this for your colour-conversion branch, sorry about that. I didn't double check the hash name, but that makes sense. The full name doesn't matter in the end.

@lambdatiger lambdatiger changed the base branch from master to colour-conversion September 27, 2024 22:01
@Drofseh Drofseh merged commit 4439bcf into Drofseh:colour-conversion Sep 27, 2024
@lambdatiger
Copy link
Author

lambdatiger commented Sep 28, 2024

Apologies about that the post merge errors, it worked/compiled on my side so I don't exactly know how that happened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants