Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements: Installer #394

Merged
merged 3 commits into from
Aug 5, 2023
Merged

Improvements: Installer #394

merged 3 commits into from
Aug 5, 2023

Conversation

Iamlooker
Copy link
Member

  • Upgrade Kotlin to 1.9.0
  • Rename Installer -> InstallManager
  • Rename BaseInstaller -> Installer

- Upgrade Kotlin to 1.9.0
- Rename `Installer` -> `InstallManager`
- Rename `BaseInstaller` -> `Installer`
@what-the-diff
Copy link

what-the-diff bot commented Aug 5, 2023

PR Summary

  • Refactoring of the Installer classes
    The Installer import was globally replaced with InstallManager. As part of this refactoring, the variable declaration type regarding Installer was also changed to InstallManager across multiple files.
  • Removal of redundant functionalities in AppDetailFragment.kt
    Certain redundant functionalities, like the scrollListener property and the updateToolbarTitle method, were removed from AppDetailFragment.kt. The updateToolbarButtons method was updated to handle changes in the toolbar title.
  • Common imports changes
    Import for InstallerQueueState was updated in AppDetailViewModel.kt matching the change in the Installer component.
  • Updates to the Kotlin and KSP versions
    Kotlin and KSP were updated to versions 1.9.0 and 1.8.22-1.0.11 respectively in the build.gradle.kts & Libs.kt files.
  • Changes in library dependencies
    In AndroidLibraryConventionPlugin.kt, the library kotlin("stdlib") was replaced with platform("org.jetbrains.kotlin:kotlin-bom:${Kotlin.version}").
  • Hilt plugin changes
    The new Hilt Convention Plugin applied the dagger.hilt.android.plugin after updating the import statements and replacing the apply("dagger.hilt.android.plugin") line with apply(Hilt.plugin).
  • Refactoring of Installer.kt and related components
    In Installer.kt, the file and interface were renamed from BaseInstaller.kt and BaseInstaller to Installer.kt and Installer, respectively. Corresponding import statements were updated in various other classes.
  • Refactoring of InstallModule.kt
    The function providesInstaller was renamed to providesInstallManager to match the new InstallManager class. The return type was updated accordingly.
  • Changes to sealed interface in InstallState.kt
    The sealed interface InstallState was replaced with an enum class InstallState. Some object declarations like Failed, Installing, and Installed were removed.
  • Addition of InstallerQueueState.kt
    A new data class InstallerQueueState with properties currentItem and queued were added, along with two extension functions isQueuedIn and isInstalling.

@Iamlooker Iamlooker closed this Aug 5, 2023
…mprovements/installer

# Conflicts:
#	app/src/main/kotlin/com/looker/droidify/ui/app_detail/AppDetailFragment.kt
#	app/src/main/kotlin/com/looker/droidify/ui/app_detail/AppDetailViewModel.kt
#	installer/src/main/java/com/looker/installer/InstallManager.kt
#	installer/src/main/java/com/looker/installer/model/InstallerQueueState.kt
@Iamlooker Iamlooker reopened this Aug 5, 2023
@Iamlooker Iamlooker merged commit b77dc05 into index-v2 Aug 5, 2023
@Iamlooker Iamlooker deleted the improvements/installer branch September 10, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant