Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Improve iOS Test CI Result on CI #750

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

[iOS] Improve iOS Test CI Result on CI #750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d3d5a59
Set -resultBundlePath
ry-itto Oct 23, 2021
89b0fa9
Add test result viewer tool
ry-itto Oct 23, 2021
a40cef0
Try to fail test
ry-itto Oct 23, 2021
0dd4384
Fix workflow
ry-itto Oct 23, 2021
eed6151
Specify working directory
ry-itto Oct 24, 2021
843600f
Fix shell argument value
ry-itto Oct 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/ios-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,11 @@ jobs:
- name: Build Test Modules
working-directory: ./ios
run: make test-modules
- name: Show XCResult
uses: kishikawakatsumi/xcresulttool@v1.0.3
with:
path: 'ios/BuildResults-ModuleTest-Debug'
if: success() || failure()

build-app-debug:
name: "iOS Buid Test on Debug Configuration"
Expand Down
2 changes: 0 additions & 2 deletions ios/Sources/Component/Tag/Tag.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ public struct Tag: View {
Text(media.title)
.font(.caption)
.foregroundColor(AssetColor.Base.white.color)
.padding(.vertical, 4)
.padding(.horizontal, 12)
.background(media.backgroundColor)
.clipShape(
CutCornerRectangle(
Expand Down
2 changes: 2 additions & 0 deletions ios/scripts/xcodebuild.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,12 @@ CONFIGURATION=${3}
SWIFT_RUN="swift run -c release --package-path Tools"
WORKSPACE=DroidKaigiFeeder.xcworkspace
PLATFORM_IOS="iOS Simulator,name=iPhone 12 Pro,OS=15.0"
RESULT_BUNDLE_PATH="BuildResults-$SCHEME-$CONFIGURATION"

echo "⚙️ Building $SCHEME..."
set -o pipefail && xcodebuild $TYPE \
-workspace $WORKSPACE \
-scheme "$SCHEME" \
-configuration $CONFIGURATION \
-resultBundlePath "$RESULT_BUNDLE_PATH" \
-destination platform="$PLATFORM_IOS" | $SWIFT_RUN xcbeautify --quiet