Add timetable detail screen Base #102

cOnigashima · 2022-09-02T22:33:57Z

Issue

close #ISSUE_NUMBER

Overview (Required)

add transition from sessions screen on item clicked
add timetable detail screen

Not yet

//TODO comment Added

design
ViewModel injection
connection data layer
module dependency problem
Bottom Navigation View
Back to sessions by navigation click

Links

figma

Screenshot

After

github-actions · 2022-09-02T22:37:31Z

app-android/src/main/java/io/github/droidkaigi/confsched2022/KaigiApp.kt

@@ -118,6 +122,12 @@ class KaigiAppScaffoldState @OptIn(ExperimentalMaterial3Api::class) constructor(
        }
    }

+    fun onTimeTableClick(timetableId : TimetableItemId){


[spotless] _{reported by reviewdog 🐶}

Suggested change

fun onTimeTableClick(timetableId : TimetableItemId){

fun onTimeTableClick(timetableId: TimetableItemId) {

github-actions · 2022-09-02T22:37:31Z

.../src/main/java/io/github/droidkaigi/confsched2022/feature/sessions/TimeTableDetailUiModel.kt

+import kotlinx.datetime.TimeZone
+import kotlinx.datetime.toInstant
+
+


[spotless] _{reported by reviewdog 🐶}

Suggested change

github-actions · 2022-09-02T22:37:31Z

.../src/main/java/io/github/droidkaigi/confsched2022/feature/sessions/TimeTableDetailUiModel.kt

+    }
+}
+
+fun fakeTimetableDetail() =  Session(


[spotless] _{reported by reviewdog 🐶}

Suggested change

fun fakeTimetableDetail() = Session(

fun fakeTimetableDetail() = Session(

github-actions · 2022-09-02T22:37:32Z

.../src/main/java/io/github/droidkaigi/confsched2022/feature/sessions/TimeTableDetailUiModel.kt

+        "INTERMEDIATE",
+    ).toPersistentList(),
+)
+


[spotless] _{reported by reviewdog 🐶}

Suggested change

github-actions · 2022-09-02T22:37:32Z

...essions/src/main/java/io/github/droidkaigi/confsched2022/feature/sessions/TimetableDetail.kt

+import androidx.compose.ui.layout.ContentScale
+import androidx.compose.ui.tooling.preview.Preview
+import androidx.compose.ui.unit.dp
+import io.github.droidkaigi.confsched2022.designsystem.theme.KaigiScaffold


[spotless] _{reported by reviewdog 🐶}

Suggested change

import io.github.droidkaigi.confsched2022.designsystem.theme.KaigiScaffold

import coil.compose.AsyncImage

import io.github.droidkaigi.confsched2022.designsystem.theme.KaigiScaffold

github-actions · 2022-09-02T22:37:33Z

...essions/src/main/java/io/github/droidkaigi/confsched2022/feature/sessions/TimetableDetail.kt

+            TimetableDetailDescription(
+                description = item.description
+            )


[spotless] _{reported by reviewdog 🐶}

Suggested change

TimetableDetailDescription(

description = item.description

)

TimetableDetailDescription(

description = item.description

)

github-actions · 2022-09-02T22:37:33Z

...essions/src/main/java/io/github/droidkaigi/confsched2022/feature/sessions/TimetableDetail.kt

+    language : String,
+    levels : PersistentList<String>,


[spotless] _{reported by reviewdog 🐶}

Suggested change

language : String,

levels : PersistentList<String>,

language: String,

levels: PersistentList<String>,

github-actions · 2022-09-02T22:37:33Z

...essions/src/main/java/io/github/droidkaigi/confsched2022/feature/sessions/TimetableDetail.kt

+
+        Text(
+            modifier = modifier,
+            text = "$startsAt $endsAt" ,


[spotless] _{reported by reviewdog 🐶}

Suggested change

text = "$startsAt $endsAt" ,

text = "$startsAt $endsAt",

github-actions · 2022-09-02T22:37:33Z

...essions/src/main/java/io/github/droidkaigi/confsched2022/feature/sessions/TimetableDetail.kt

+                    Spacer(
+                        modifier = modifier.padding(horizontal = 16.dp),
+                    )
+                    //TODO ClickableにしてSpeaker詳細へ遷移


[spotless] _{reported by reviewdog 🐶}

Suggested change

//TODO ClickableにしてSpeaker詳細へ遷移

// TODO ClickableにしてSpeaker詳細へ遷移

github-actions · 2022-09-02T22:37:33Z

...essions/src/main/java/io/github/droidkaigi/confsched2022/feature/sessions/TimetableDetail.kt

+        uiModel = TimeTableDetailUiModel(Loaded(fakeTimetableDetail()))
+    )
+}
+


[spotless] _{reported by reviewdog 🐶}

Suggested change

cOnigashima · 2022-09-02T22:46:56Z

app-android/build.gradle.kts

@@ -43,6 +43,7 @@ dependencies {
    implementation(projects.coreData)
    implementation(projects.coreDesignsystem)
    implementation(projects.coreUi)
+    implementation(projects.coreModel)


I think this dependency is bad ... but I don't know what to do

Is this for TimetableItemId? I think this is not so bad. Because the model is used everywhere in this project.

Is this for TimetableItemId?

That's right.

the model is used everywhere in this project.

I see. Thank you very much!!

cOnigashima · 2022-09-02T23:14:44Z

...ssions/src/main/java/io/github/droidkaigi/confsched2022/feature/sessions/SessionsNavGraph.kt

    composable(route = SessionsNavGraph.sessionRoute) {
-        SessionsScreenRoot(onNavigationIconClick = onNavigationIconClick)
+        SessionsScreenRoot(


[Q]
Should I make another NavGraph Class , and move them ?

I think it is ok. 👍

takahirom · 2022-09-02T23:53:22Z

...essions/src/main/java/io/github/droidkaigi/confsched2022/feature/sessions/TimetableDetail.kt

+}
+
+@Composable
+fun TimetableDetailDescription(


…screen

github-actions · 2022-09-03T08:01:53Z

core-model/src/commonMain/kotlin/io/github/droidkaigi/confsched2022/model/TimetableItem.kt

+            "INTERMEDIATE",
+        ).toPersistentList(),
+    )
+}


[spotless] _{reported by reviewdog 🐶}

Suggested change

}

}

takahirom

Let's merge first

...ions/src/test/java/io/github/droidkaigi/confsched2022/feature/sessions/SessionsScreenTest.kt

cOnigashima · 2022-09-03T11:42:07Z

Thanks for fixing!

takahirom · 2022-09-03T11:43:11Z

🙏

taijionishifc added 3 commits September 3, 2022 07:31

add timetableDetail transition

3591797

add Coil

1486b72

add Timetable Detail Screen

c271530

github-actions bot reviewed Sep 2, 2022

View reviewed changes

cOnigashima commented Sep 2, 2022

View reviewed changes

Format

fc0f877

takahirom reviewed Sep 2, 2022

View reviewed changes

takahirom added 3 commits September 3, 2022 08:58

Put Japanese into English in comment

3a694bc

Merge remote-tracking branch 'origin/main' into add_timetable_detail_…

981ddcd

…screen

Use fake method

2e57610

github-actions bot reviewed Sep 3, 2022

View reviewed changes

takahirom approved these changes Sep 3, 2022

View reviewed changes

takahirom added 2 commits September 3, 2022 18:25

Fix spotless

240e992

Fix test

6a1712d

github-actions bot reviewed Sep 3, 2022

View reviewed changes

...ions/src/test/java/io/github/droidkaigi/confsched2022/feature/sessions/SessionsScreenTest.kt Outdated Show resolved Hide resolved

...ions/src/test/java/io/github/droidkaigi/confsched2022/feature/sessions/SessionsScreenTest.kt Outdated Show resolved Hide resolved

Fix test

759643b

cOnigashima merged commit 90729dd into main Sep 3, 2022

cOnigashima deleted the add_timetable_detail_screen branch September 3, 2022 11:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add timetable detail screen Base #102

Add timetable detail screen Base #102

cOnigashima commented Sep 2, 2022 •

edited

Loading

github-actions bot Sep 2, 2022

github-actions bot Sep 2, 2022

github-actions bot Sep 2, 2022

github-actions bot Sep 2, 2022

github-actions bot Sep 2, 2022

github-actions bot Sep 2, 2022

github-actions bot Sep 2, 2022

github-actions bot Sep 2, 2022

github-actions bot Sep 2, 2022

github-actions bot Sep 2, 2022

cOnigashima Sep 2, 2022

takahirom Sep 2, 2022

cOnigashima Sep 3, 2022 •

edited

Loading

cOnigashima Sep 2, 2022 •

edited

Loading

takahirom Sep 2, 2022

takahirom Sep 2, 2022

github-actions bot Sep 3, 2022

takahirom left a comment

cOnigashima commented Sep 3, 2022

takahirom commented Sep 3, 2022

	fun onTimeTableClick(timetableId : TimetableItemId){
	fun onTimeTableClick(timetableId: TimetableItemId) {

		import kotlinx.datetime.TimeZone
		import kotlinx.datetime.toInstant

	fun fakeTimetableDetail() = Session(
	fun fakeTimetableDetail() = Session(

	import io.github.droidkaigi.confsched2022.designsystem.theme.KaigiScaffold
	import coil.compose.AsyncImage
	import io.github.droidkaigi.confsched2022.designsystem.theme.KaigiScaffold

	//TODO ClickableにしてSpeaker詳細へ遷移
	// TODO ClickableにしてSpeaker詳細へ遷移

Add timetable detail screen Base #102

Add timetable detail screen Base #102

Conversation

cOnigashima commented Sep 2, 2022 • edited Loading

Issue

Overview (Required)

Not yet

Links

Screenshot

github-actions bot Sep 2, 2022

Choose a reason for hiding this comment

github-actions bot Sep 2, 2022

Choose a reason for hiding this comment

github-actions bot Sep 2, 2022

Choose a reason for hiding this comment

github-actions bot Sep 2, 2022

Choose a reason for hiding this comment

github-actions bot Sep 2, 2022

Choose a reason for hiding this comment

github-actions bot Sep 2, 2022

Choose a reason for hiding this comment

github-actions bot Sep 2, 2022

Choose a reason for hiding this comment

github-actions bot Sep 2, 2022

Choose a reason for hiding this comment

github-actions bot Sep 2, 2022

Choose a reason for hiding this comment

github-actions bot Sep 2, 2022

Choose a reason for hiding this comment

cOnigashima Sep 2, 2022

Choose a reason for hiding this comment

takahirom Sep 2, 2022

Choose a reason for hiding this comment

cOnigashima Sep 3, 2022 • edited Loading

Choose a reason for hiding this comment

cOnigashima Sep 2, 2022 • edited Loading

Choose a reason for hiding this comment

takahirom Sep 2, 2022

Choose a reason for hiding this comment

takahirom Sep 2, 2022

Choose a reason for hiding this comment

github-actions bot Sep 3, 2022

Choose a reason for hiding this comment

takahirom left a comment

Choose a reason for hiding this comment

cOnigashima commented Sep 3, 2022

takahirom commented Sep 3, 2022

cOnigashima commented Sep 2, 2022 •

edited

Loading

cOnigashima Sep 3, 2022 •

edited

Loading

cOnigashima Sep 2, 2022 •

edited

Loading