Using method reference for better memorization. #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
deploygate-distribution
takahirom
reviewed
Sep 25, 2022
| onClickDrawerItem = { drawerItem -> | ||
| kaigiAppScaffoldState.navigate(drawerItem) | ||
| } | ||
| onClickDrawerItem = kaigiAppScaffoldState::navigate, |
There was a problem hiding this comment.
May I ask if we can fix the problem by adding Immutable to KaigiAppScaffoldState? 👀
There was a problem hiding this comment.
Good idea. Since KaigiAppScaffoldState as a DrawerState which is Stable, should we use Stable for the KaigiAppScaffoldState instead of Immutable?
There was a problem hiding this comment.
I think so too!
But I think we should have both of codes, method reference and stable. So now, I merge this PR. Thanks
There was a problem hiding this comment.
we should have both of codes, method reference and stable
@takahirom Agree. Thanks for merging. If you need any follow-up please assign me to a ticket.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
viewModel.methodare not effectively remembered, becauseviewModelis not a stable type.viewModeldoesn't affect the stabability of method reference. In another word, it is stable.Links
Screenshot
droidkaigi_drawer_session_lambda.1080p.mov
droidkaigi_drawer_session_method_reference.1080p.mov