[issue-406] Introduce Dynamic Color #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
September 27, 2022 04:10
|
I will write more details later, sorry 🙏 |
|
Please run |
added 2 commits
September 27, 2022 22:28
…sue-406_dynamic_color
|
It seems that you need to supress or do something for this lint👀 |
|
@mona-apk Thanks! I make some refactoring and add a trick. |
takahirom
force-pushed
the
issue-406_dynamic_color
branch
from
11a51f5
to
c50d20e
Compare
takahirom
force-pushed
the
issue-406_dynamic_color
branch
from
c50d20e
to
b7502a6
Compare
|
Thank you very much...! |
mona-apk
changed the title
github-actions
bot
temporarily deployed
to
deploygate-distribution
mona-apk
commented
Sep 28, 2022
| content: @Composable () -> Unit | ||
| ) { | ||
| val colorScheme = if (isDynamicColorEnabled) { | ||
| dynamicDarkColorScheme(LocalContext.current) |
There was a problem hiding this comment.
It seems difficult to apply dynamicLightColorScheme because Color.White is set in Text Composables 🤔
github-actions
bot
temporarily deployed
to
deploygate-distribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
Links
Screenshot