✨ Add implement open session detail from notification #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are differences in Compose previews: |
takahirom
reviewed
Oct 2, 2022
Comment on lines
179
to
181
| sessionIdFromNotification?.let { | ||
| kaigiAppScaffoldState.onTimeTableClick(TimetableItemId(it)) | ||
| } |
There was a problem hiding this comment.
I think this onTimeTableClick can be called many times. How about using Launched Effect?
Suggested change
| sessionIdFromNotification?.let { | |
| kaigiAppScaffoldState.onTimeTableClick(TimetableItemId(it)) | |
| } | |
| LaunchedEffect(sessionIdFromNotification) { | |
| sessionIdFromNotification?.let { | |
| kaigiAppScaffoldState.onTimeTableClick(TimetableItemId(it)) | |
| } | |
| } |
|
Looks good. Please check small point 🙏 |
|
There are differences in Compose previews: |
|
Thank you for providing the notification to DroidKaigi! |
Corvus400
deleted the
feature/implement_open_session_detail_from_notification
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
Links
Movie
after.mp4