Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Tab indicator design #96

Merged
merged 2 commits into from
Sep 2, 2022
Merged

Implemented Tab indicator design #96

merged 2 commits into from
Sep 2, 2022

Conversation

NUmeroAndDev
Copy link
Collaborator

Issue

  • close #ISSUE_NUMBER

Overview (Required)

  • Implemented Tab indicator design.
  • Implement Tab and Pager synchronization.

Links

Screenshot

Before After
device-2022-09-02-214600.mp4

@NUmeroAndDev NUmeroAndDev self-assigned this Sep 2, 2022
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒


@Composable
internal fun SessionDayTab(
index: Int,
day: DroidKaigi2022Day,
selectedTab: Int,
selected: Boolean,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

TabIndicator(
modifier = Modifier
.pagerTabIndicatorOffset(pagerState, it)
.zIndex(-1f),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@takahirom takahirom merged commit a5855fb into main Sep 2, 2022
@takahirom takahirom deleted the impl_tab_design branch September 2, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants