Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 [Proposal][SearchScreenTest] The robots were separated according to their roles. #1000

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Corvus400
Copy link
Contributor

Issue

  • None.

Overview (Required)

  • As the robot was becoming bloated, I thought it might be a good idea to separate it into three parts: a robot that performs setup, a robot that operates the semantics tree, and a robot that performs checks, so I tried introducing it into SearchScreenTest.

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 8, 2024 03:07 Inactive
Copy link

github-actions bot commented Sep 8, 2024

Detekt check failed. Please run ./gradlew detekt --auto-correct to fix the issues.

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 8, 2024 03:10 Inactive
@Corvus400 Corvus400 marked this pull request as ready for review September 8, 2024 03:26
@takahirom
Copy link
Member

What I want to focus on is that when we create or modify something, it's better if the number of files or the distance of each edit we need to modify is small. I think if we filter something on the search screen, we want to check the filter, and this change requires us to make multiple file modifications.

@Corvus400
Copy link
Contributor Author

I see...
Since the current scale is this number of lines, if we add more tests, it is easy to predict that the number of lines will easily reach four or five digits, so I would like to hear any good ideas you may have. 🙇

@takahirom
Copy link
Member

takahirom commented Sep 8, 2024

I think we need to focus on the developer's workflow to understand which changes are made together and consolidate them into the same class or something similar. This is what you changed, and I think we can create a SearchFilterRobot.

ab21560

I believe this kind of change is better because it makes our development more smooth.

class SearchScreenRobot {
  val searchFilterRobot 

  class SearchFilterRobot()
}

@Corvus400
Copy link
Contributor Author

Understood. 🫡
Instead of dividing the robot into three parts, I'll try dividing the classes within the robot and moving the processing to them. 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants