Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implementation foundation:1.8.0-alpha01 instead of resolutionStrategy #1032

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

yt8492
Copy link
Contributor

@yt8492 yt8492 commented Sep 10, 2024

Issue

Overview (Required)

  • define composeFoundation in version catalog
  • implementation composeFoundation in KmpComposePlugin androidMain dependencies
  • remove resolutionStrategy

Links

@@ -48,6 +48,7 @@ class KmpComposePlugin : Plugin<Project> {
dependencies {
implementation(libs.library("androidxActivityActivityCompose"))
implementation(libs.library("composeUiToolingPreview"))
implementation(libs.library("composeFoundation"))
Copy link
Contributor Author

@yt8492 yt8492 Sep 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[memo] foundation:1.8.0-alpha01 is not yet provided from org.jetbrains.compose.foundation and only provide from androidx.compose.foundation.

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 10, 2024 23:10 Inactive
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for your contribution!

@takahirom takahirom merged commit a4906df into DroidKaigi:main Sep 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use implement(xxx) for foundation:1.8.0-alpha01 instead of resolutionStrategy
2 participants