Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added color theme #65

Merged
merged 1 commit into from
Jun 23, 2024
Merged

Added color theme #65

merged 1 commit into from
Jun 23, 2024

Conversation

shin-usu
Copy link
Contributor

Overview (Required)

Added Theme module and common color set.
As with the 2023 app, it is automatically generated from the Asset catalog using SwiftGenPlugin.

@shin-usu shin-usu marked this pull request as ready for review June 23, 2024 11:30
shin-usu
shin-usu commented Jun 23, 2024
View reviewed changes
charles-b-stb
charles-b-stb approved these changes Jun 23, 2024
View reviewed changes
Copy link
Contributor

@charles-b-stb charles-b-stb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but fix the conflicts first.

ry-itto
ry-itto approved these changes Jun 23, 2024
View reviewed changes
Copy link
Member

@ry-itto ry-itto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/DroidKaigi/conference-app-2023/blob/main/app-ios/Modules/Sources/Theme/Bundle.swift

Above file might be needed 👀
But in this PR, it is okey. (deal with it when it happens)

@shin-usu
Copy link
Contributor Author

@ry-itto
Thank you for your comment!
This is the code that addresses the Issue here, right?
It looks old with xcode12 content, but does it still occur?
As per your comment, I won't address it in the PR here, but I'll keep in mind that we can address the issue here when it occurs.

@ry-itto
Copy link
Member

ry-itto commented Jun 23, 2024

It looks old with xcode12 content, but does it still occur?

Yes, At least it remained as of last year 😭

@shin-usu shin-usu force-pushed the feature/color_set_ios branch from 0ca0777 to 5f08b6e Compare June 23, 2024 14:44
@shin-usu
Copy link
Contributor Author

Oh, I see...
I would have been quite worried if you hadn't told me.
Thank you very much😄 ❤️

@shin-usu shin-usu merged commit 1c35b9e into main Jun 23, 2024
@shin-usu shin-usu deleted the feature/color_set_ios branch June 23, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charles-b-stb charles-b-stb charles-b-stb approved these changes

@ry-itto ry-itto ry-itto approved these changes

@MrSmart00 MrSmart00 Awaiting requested review from MrSmart00

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shin-usu @ry-itto @charles-b-stb