Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] ProfileCard Base (Input) #714

Merged
merged 6 commits into from
Aug 23, 2024
Merged

[iOS] ProfileCard Base (Input) #714

merged 6 commits into from
Aug 23, 2024

Conversation

ry-itto
Copy link
Member

@ry-itto ry-itto commented Aug 21, 2024

Issue

Overview (Required)

  • Add ProfileCard feature base (not swift6 conformance code)
  • Show share view (TODO on other PR)
  • Reflect saved data (TODO on other PR)

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Image1 Image2

Movie (Optional)

Before After
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-08-22.at.02.14.02.mp4

@ry-itto ry-itto marked this pull request as ready for review August 21, 2024 17:12
@github-actions github-actions bot temporarily deployed to deploygate-distribution August 21, 2024 17:15 Inactive
Copy link

Detekt check failed. Please run ./gradlew detekt --auto-correct to fix the issues.

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 22, 2024 01:38 Inactive
@github-actions github-actions bot temporarily deployed to deploygate-distribution August 22, 2024 02:38 Inactive
Copy link
Contributor

@shin-usu shin-usu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 🎉

I left nits comment, but there is not a high need to modify it

@@ -0,0 +1,85 @@
import SwiftUI
import _PhotosUI_SwiftUI
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow,first time I have seen it.👀

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, certain types are not available without importing this 😢

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 23, 2024 03:13 Inactive
@ry-itto ry-itto merged commit f1da417 into main Aug 23, 2024
9 checks passed
@ry-itto ry-itto deleted the ios-profile-card branch August 23, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] Profile Card Base
2 participants