Crash iOS app when throwing error on kotlin flow #818
Conversation
|
Detekt check failed. Please run |
shin-usu
force-pushed
the
feature/ios-flow-crash
branch
from
2486ce4 to
7e9a7c5
Compare
|
Detekt check failed. Please run |
shin-usu
force-pushed
the
feature/ios-flow-crash
branch
from
7e9a7c5 to
ba6ace7
Compare
shin-usu
force-pushed
the
feature/ios-flow-crash
branch
from
ba6ace7 to
f2a7e76
Compare
shin-usu
changed the title
shin-usu
requested review from
takahirom,
MrSmart00,
ry-itto and
charles-b-stb
|
It seems this is the issue: touchlab/SKIE#19. |
| @@ -36,6 +38,10 @@ public class DefaultContributorsRepository( | |||
| refresh() | |||
| } | |||
| } | |||
| .catch { | |||
| Logger.e("Fail getContributorStream: $it") | |||
There was a problem hiding this comment.
I think we can pass throwable to Logger.e parameter 👀
| @@ -36,6 +38,10 @@ public class DefaultContributorsRepository( | |||
| refresh() | |||
| } | |||
| } | |||
| .catch { | |||
There was a problem hiding this comment.
How about adding a comment for each .catch block?
// SKIE doesn't support throwing exceptions from Flow.
// For more information, please refer to https://github.com/touchlab/SKIE/discussions/19 .
| if (first) { | ||
| first = false | ||
| Logger.d("DefaultSessionsRepository onStart getTimetableStream()") | ||
| sessionCacheDataStore.save(sessionsApi.sessionsAllResponse()) |
There was a problem hiding this comment.
The sessionsApi.sessionsAllResponse is likely to throw an error.
try {
sessionCacheDataStore.save(sessionsApi.sessionsAllResponse())
} catch (e: Exception) {
// SKIE doesn't support throwing exceptions from Flow.
// For more information, please refer to https://github.com/touchlab/SKIE/discussions/19 .
coroutineContext.ensureActive()
Logger.e(e, "Fail to refresh Timetable in getTimetableStream()")
}
|
@takahirom |
|
@takahirom |
Issue
Overview (Required)
When error is thrown on kotlin flow, iOS app crash.
According to this article, Skie does not propagate errors that occur in Flow to the iOS side.
https://touchlab.co/skie-migration?ti=44D6E96AB6894C3C883219A3B4#flow-support
Therefore, I added error catch logic to kotlin flow.
In fact, I would like to pass the Result type to iOS for error handling on the iOS side, but since the type would be AnyObject, our priority at this stage is to avoid crashes.
Links
Screenshot (Optional if screenshot test is present or unrelated to UI)
Movie (Optional)