✨ [Compose Multiplatform] License screen can now be opened. #820
+29
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corvus400
commented
Aug 26, 2024
Comment on lines
+67
to
+69
| private object ExternalNavControllerLink { | ||
| var onLicenseScreenRequest: (() -> Unit)? = null | ||
| } |
There was a problem hiding this comment.
I do not like this implementation very much. 🤔
If there is a better way to implement it, we will follow it. 🫡
|
@takahirom @ry-itto |
…feature/can_be_display_license_screen_compose_multiplatform # Conflicts: # app-ios-shared/src/commonMain/kotlin/io/github/droidkaigi/confsched/shared/IosComposeKaigiApp.kt
|
I'm also not sure. I think this is related. Could you check how the contributor screen is used? conference-app-2024/app-ios/Package.swift Line 85 in 86ca73a |
|
I'm not sure if iOS has a dependency rule for this, like we shouldn't use the feature module from KMPClient. 👀 |
|
@takahirom |
takahirom
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
Links
Movie (Optional)
after.mov