Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent multiple transitions (only transitions by Navigation) #848

Merged

Conversation

nashcft
Copy link
Contributor

@nashcft nashcft commented Aug 28, 2024

Issue

Overview (Required)

  • wrap onClick callbacks that run a transition by Navigation with dropUnlessResumed
  • replace handleOnClickIfNotNavigating with dropUnlessResumed

Note

  • I didn't apply dropUnlessResumed to all click events that run a transition because the safeguard by the function doesn't work for the transition that launches an Activity. You can check the behaviour on the About screen by clicking an item in the Credits section and one in the Others section (except Settings) simultaneously.
note.mp4

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Movie (Optional)

\ Before After
Timetable: sessions (list)
b_timetable_list_sessions.mp4
a_timetable_list_sessions.mp4
Timetable: sessions (grid)
b_timetable_grid_sessions.mp4
a_timetable_grid_sessions.mp4
Timetable: session and search
b_timetable_session_search.mp4
a_timetable_session_search.mp4
About
b_about.mp4
a_about.mp4

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 28, 2024 12:47 Inactive
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for applying this new method.

@takahirom takahirom added the awesome Label for project-applicable insights or remarkable technologies. label Aug 29, 2024
@takahirom takahirom merged commit b0379a7 into DroidKaigi:main Aug 29, 2024
7 checks passed
@nashcft nashcft deleted the navigation-prevent-multiple-transition branch August 30, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awesome Label for project-applicable insights or remarkable technologies.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent multiple transitions
2 participants