Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move notCompatibleWithConfigurationCache. #897

Merged
merged 1 commit into from
Sep 1, 2024
Merged

Move notCompatibleWithConfigurationCache. #897

merged 1 commit into from
Sep 1, 2024
+6 −9

Conversation

Aniokrait
Copy link
Contributor

Issue

Overview (Required)

  • Moved task for KspTaskNative to KmpPlugin
  • Remove task for KotlinNativeLink from KmpKtorfitPlugin because it doesn't affect build any more (I don't know why though).

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After

Movie (Optional)

Before After

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 31, 2024 06:55 Inactive
takahirom
takahirom approved these changes Sep 1, 2024
View reviewed changes
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Tidiness is key to success!

@takahirom takahirom merged commit ffadf8d into DroidKaigi:main Sep 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirom takahirom takahirom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move notCompatibleWithConfigurationCache config to KmpPlugin from KmpKtorfitPlugin
2 participants
@Aniokrait @takahirom