-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ [ShareableCardContent] Display a shadow instead of a border around the profile picture. #906
Open
Corvus400
wants to merge
21
commits into
DroidKaigi:main
Choose a base branch
from
Corvus400:design/display_a_shadow_instead_of_a_line
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+67
−47
Open
Changes from 4 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
a6da413
:wastebasket: The process of displaying the border has been removed.
Corvus400 c0b750e
:recycle: We have implemented a process to ensure that the profile ca…
Corvus400 54230f9
:wrench: ./gradlew detekt --auto-correct
Corvus400 34f00d1
Merge branch 'main' into design/display_a_shadow_instead_of_a_line
Corvus400 a3e7f02
Merge branch 'main' into design/display_a_shadow_instead_of_a_line
Corvus400 8bd53f5
Merge branch 'main' of github.com:Corvus400/conference-app-2024 into …
Corvus400 a386dc2
:wrench: ./gradlew detekt --auto-correct
Corvus400 88c9986
Merge branch 'main' into design/display_a_shadow_instead_of_a_line
Corvus400 588db37
:wrench: The processing has been simplified.
Corvus400 d0f8deb
:wrench: ./gradlew detekt --auto-correct
Corvus400 0b1da73
Merge branch 'main' into design/display_a_shadow_instead_of_a_line
Corvus400 519a2bb
Merge branch 'main' into design/display_a_shadow_instead_of_a_line
Corvus400 6006238
Merge branch 'main' into design/display_a_shadow_instead_of_a_line
Corvus400 081f99e
Merge branch 'main' into design/display_a_shadow_instead_of_a_line
Corvus400 5b2824d
Merge branch 'main' into design/display_a_shadow_instead_of_a_line
Corvus400 6867e80
Merge branch 'main' into design/display_a_shadow_instead_of_a_line
Corvus400 8b16b8e
Merge branch 'main' into design/display_a_shadow_instead_of_a_line
Corvus400 e7bce0f
Merge branch 'main' into design/display_a_shadow_instead_of_a_line
Corvus400 7246053
Merge branch 'main' into design/display_a_shadow_instead_of_a_line
Corvus400 ddd697d
Merge branch 'main' into design/display_a_shadow_instead_of_a_line
Corvus400 5690ecd
Merge branch 'main' into design/display_a_shadow_instead_of_a_line
Corvus400 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be difficult but, how about using Brush as the card surface effect?
https://developer.android.com/develop/ui/compose/graphics/draw/brush
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@takahirom
I tried it for a few hours, but unfortunately I couldn't get the same expression as the current implementation. 🥺
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And this you might tried but how about just using .shadow(elevation= )?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@takahirom
Unfortunately, that method didn't work either. 😞
Incidentally, I tried various things afterwards, such as surrounding it with a card to see if the elevation would be displayed, but the elevation is ignored in the same way as the shadow. 💀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@takahirom
Thank you for waiting. 🙇
I tried using the Brush method.
I think it's simpler and easier to understand than the original processing, but what do you think?
It's a little different from the original design... but if you don't want to make it too complicated, I think this is a good compromise. 🙏