Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deprecated compiler options #974

Merged

Conversation

Aniokrait
Copy link
Contributor

Issue

Overview (Required)

  • Raplace kotlinOptions to compilerOptions
  • Replace buildDir to layout.buildDirectory
  • Change reciever of kotlinOptions from TestedExtension to Project
    • TestedExtension somehow causes Extension of type 'KotlinAndroidProjectExtension' does not exist.
  • Move dsl function kotlinOptions from KotlinGradleDsl.kt to AndroidGradleDsl.kt because it now focuses only android target
  • Add libraryAndroidOptions
    • kotlinAndroidOptions can be used only org.jetbrains.kotlin.android is applied, otherwise Extension of type 'KotlinAndroidProjectExtension' does not exist happens

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After

Movie (Optional)

Before After

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 5, 2024 10:04 Inactive
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I didn't know how we could replace it. Thank you for your expertise.

@takahirom takahirom merged commit e81b8ad into DroidKaigi:main Sep 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Compiler Options instead of deprecated Kotlin Options.
2 participants