Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto Mission Assistant #754

Closed
5 tasks
arthurbenemann opened this issue May 10, 2014 · 18 comments
Closed
5 tasks

Auto Mission Assistant #754

arthurbenemann opened this issue May 10, 2014 · 18 comments
Assignees

Comments

@arthurbenemann
Copy link
Member

The mode detail fragment for auto missions should aid the user during an auto missiom. Some of the possible features are:

  • Progress bar
  • Estimated time to finish
  • Distance to finish
  • Sumary of next waypoint
  • Buttons to rewind/advance/pause the mission
@m4gr3d
Copy link
Member

m4gr3d commented May 10, 2014

@arthurbenemann is it possible to have Jason come up with a design for the mission assistant.
Having a clear goal/ui target will help spread and speed up the development.

@arthurbenemann
Copy link
Member Author

Certainly, I`ll discuss it with him Monday.

2014-05-10 10:40 GMT-07:00 Fredia Huya-Kouadio notifications@github.com:

@arthurbenemann https://github.com/arthurbenemann is it possible to
have Jason come up with a design for the mission assistant.
Having a clear goal/ui target will help spread and speed up the
development.


Reply to this email directly or view it on GitHubhttps://github.com//issues/754#issuecomment-42748841
.

Arthur Benemann

@arthurbenemann arthurbenemann mentioned this issue May 10, 2014
7 tasks
@azrin1972
Copy link
Contributor

I'm currently trying to built the same thing. I'll wait for the discussion outcome.

Azrin Aris

On 11/05/2014, at 2:10, Arthur Benemann notifications@github.com wrote:

Certainly, I`ll discuss it with him Monday.

2014-05-10 10:40 GMT-07:00 Fredia Huya-Kouadio notifications@github.com:

@arthurbenemann https://github.com/arthurbenemann is it possible to
have Jason come up with a design for the mission assistant.
Having a clear goal/ui target will help spread and speed up the
development.


Reply to this email directly or view it on GitHubhttps://github.com//issues/754#issuecomment-42748841
.

Arthur Benemann

Reply to this email directly or view it on GitHub.

@jason4short
Copy link
Contributor

Here you go!

auto_mode-control

@m4gr3d
Copy link
Member

m4gr3d commented Jun 6, 2014

@jason4short @arthurbenemann looks good, although how do we get about estimating the mission remaining time. That would be highly dependent on the type of waypoint, their duration time (if applicable) as well as the drone's speed.

Also, does 'rewind' means return to the previous waypoint, and 'advance' means skip the upcoming waypoint?

@arthurbenemann
Copy link
Member Author

@ne0fhyk Rewind means setCurrentWp(drone.getCurrentWP()-1), forward means setCurrentWp(drone.getCurrentWP()+1)

@jason4short
Copy link
Contributor

I have no idea about the mission time. It was Arthur's suggestion!

@bbasso
Copy link

bbasso commented Jun 8, 2014

I think the idea was to just look at the WPNAV_SPEED and the remaining distance, since changing speed during a mission is not something done that often. Also, I like the idea of progress bars, especially if the completion time is just an estimate. People are used to seeing progress bars for installing software and such, and those hang all the time--I think it would help drive home the point that it's just an estimate.

@jason4short
Copy link
Contributor

I added WP speed to the panel. I've always wanted to control this during flight.
Also added restart.

mission_control

@bbasso
Copy link

bbasso commented Jun 9, 2014

Does change the speed for just that waypoint or all waypoints? I like the
idea of being able to change the speed for the whole mission, but dont see
a huge need for individual waypoints. We shoudl be careful to not add too
many options for each mission item. For example, the WP delay
parameter--we may use it a fair amount, but do other people? I think it's
pretty fringe.

@arthurbenemann
Copy link
Member Author

@bbasso This side panel is for flight mode details, in this case for the auto mode mission.

Changes like speed would be global.

@azrin1972
Copy link
Contributor

Having options is good but I agree with you that too many options might just be confusing for users.

I personally like to have individual delay and speed. What I would like to suggest is to have a check box 'advance parameter' that when checked will reveal the extra settings for each WP.

I can start looking into that if everyone agreed to it.

Just an idea though...

Azrin Aris

On 10/06/2014, at 6:47, Brandon Basso notifications@github.com wrote:

Does change the speed for just that waypoint or all waypoints? I like the
idea of being able to change the speed for the whole mission, but dont see
a huge need for individual waypoints. We shoudl be careful to not add too
many options for each mission item. For example, the WP delay
parameter--we may use it a fair amount, but do other people? I think it's
pretty fringe.

Brandon Basso, PhD :: Senior Research and Development Engineer :: 3D
Robotics :: Berkeley, CA

On Mon, Jun 9, 2014 at 4:50 PM, jason4short notifications@github.com
wrote:

I added WP speed to the panel. I've always wanted to control this during
flight.
Also added restart.

[image: mission_control]
https://cloud.githubusercontent.com/assets/3344856/3222548/b1094356-f017-11e3-8a43-e41d9a5e5312.png

Reply to this email directly or view it on GitHub
#754 (comment)
.


Reply to this email directly or view it on GitHub.

@bbasso
Copy link

bbasso commented Jun 10, 2014

@azrin1972, I like the idea of an Advanced check box which reveals options like speed and delay. My sense from watching users fly our copters is that many people do not have need for a WP delay, which is something that should be more part of a mission script than a native basic mission behavior. Just a guess at what would be useful/interesting for most users:

-mission-wide speed control, changeable in real time
-mission-wide yaw behavior, changeable in real time
-WP navigation: spline, etc

So essentially, just mission wide parameters.

@azrin1972
Copy link
Contributor

Ok will look in to it. A lot of code has change... I'm starting all over again :)

Azrin Aris

On 10/06/2014, at 10:09, Brandon Basso notifications@github.com wrote:

@azrin1972, I like the idea of an Advanced check box which reveals options like speed and delay. My sense from watching users fly our copters is that many people do not have need for a WP delay, which is something that should be more part of a mission script than a native basic mission behavior. Just a guess at what would be useful/interesting for most users:

-mission-wide speed control, changeable in real time
-mission-wide yaw behavior, changeable in real time
-WP navigation: spline, etc

So essentially, just mission wide parameters.


Reply to this email directly or view it on GitHub.

@arthurbenemann arthurbenemann added this to the Plane support milestone Sep 23, 2014
@m4gr3d m4gr3d self-assigned this Oct 24, 2014
@m4gr3d
Copy link
Member

m4gr3d commented Oct 25, 2014

@codyfinn
Copy link

In my team's experience we found if useful to check the mission for a takeoff, and landing waypoint before takeoff. Would something like this be a useful addition to the assistant? I have some ideas on how to implement it in way that I think would make it simple.

@m4gr3d
Copy link
Member

m4gr3d commented Nov 13, 2014

We already have an option to automatically insert takeoff and land/rtl
waypoint if missing before sending the mission to the drone.
On Nov 12, 2014 8:26 PM, "Cody Finn" notifications@github.com wrote:

In my team's experience we found if useful to check the mission for a
takeoff, and landing waypoint before takeoff. Would something like this be
a useful addition to the assistant? I have some ideas on how to implement
it in way that I think would make it simple.


Reply to this email directly or view it on GitHub
#754 (comment)
.

@m4gr3d m4gr3d assigned TShapinsky and unassigned m4gr3d Jul 6, 2015
@m4gr3d
Copy link
Member

m4gr3d commented Jul 31, 2015

Fixed by pr #1538

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants