Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android: Draw the received camera footprints #1265

Merged
merged 1 commit into from
Nov 11, 2014
Merged

Android: Draw the received camera footprints #1265

merged 1 commit into from
Nov 11, 2014

Conversation

arthurbenemann
Copy link
Member

screenshot_2014-11-10-15-55-54

arthurbenemann added a commit that referenced this pull request Nov 11, 2014
@arthurbenemann
Merge pull request #1265 from DroidPlanner/cameraFootprints
52cd147 
Android: Draw the received camera footprints
@arthurbenemann arthurbenemann merged commit 52cd147 into master Nov 11, 2014
@arthurbenemann arthurbenemann deleted the cameraFootprints branch November 11, 2014 00:33
@arthurbenemann arthurbenemann mentioned this pull request Nov 11, 2014
Closed
4 tasks
@bbasso
Copy link

bbasso commented Nov 11, 2014

5 Stars!

@squilter
Copy link
Member

@arthurbenemann In that screenshot the FlightActionsFragment is on the left. Shouldn't it be centered?

@arthurbenemann
Copy link
Member Author

@squilter It was a layout change made a couple of releases ago by @ne0fhyk

@squilter
Copy link
Member

Ok. Just making sure that was on purpose.

@m4gr3d
Copy link
Member

m4gr3d commented Nov 11, 2014

@squilter, done on purpose to make room for the telemetry fragment when
opened.
On Nov 10, 2014 5:23 PM, "squilter" notifications@github.com wrote:

Ok. Just making sure that was on purpose.

—
Reply to this email directly or view it on GitHub
#1265 (comment)
.

@ghost
Copy link

ghost commented Nov 12, 2014

@arthurbenemann Looks good! To avoid an all blue area/map it might be an idea to highlight only the current footprint and to set the previous more transparent - or frames only.
@ALL I like the FlightActionsFragment being on the left (or right). I raised this a while ago (#1121). However, it seems that it is not implemented for tablets - or?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arthurbenemann @bbasso @squilter @m4gr3d