-
Notifications
You must be signed in to change notification settings - Fork 7
[UNTESTED] Static linking on binaries #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UNTESTED] Static linking on binaries #1
Conversation
I'll pull and test on my CI/CD in a few hours to see the delta in bundle size. It's currently around 12-14MB, and shouldn't grow too much from there (anything new will be code and small assets). You should be able to test the builds by using By the way, the Windows build environment automatically configures OpenSSL to be statically linked via the |
I will be testing it later today and update this comment with an update ;) thanks! |
@alessiodam any update? |
Nope, I still have no idea why it didn't work for him. |
I'll take a look in about an hour. I'll give you an update then and see if I can merge and close this |
As per my above comment, OpenSSL is already statically linked. I don't think this does anything? |
Just taking a look at it, I don't think that we'd be able to do this in any case. Apparently this is a missing feature in rust that specifically isn't being supported in the current roadmap for the language (Rust Issue 83481). I'll include the release optimisations though because those are good points |
Merged. Closing this now because I don't see a way to get this to work. |
#1). Needs tests when actual functions are implemented
…manifest minimal example in the server (#1)
… in gameID, GameVersion, and maxThreads from FE (#1)
PR Description:
Prevent Missing OpenSSL Libraries on Windows/Linux (Non-dev Instances)
This PR modifies the build process to generate statically linked binaries for Windows and Linux. By including OpenSSL in the build and disabling dynamic linking, this ensures that the application can run smoothly on non-dev machines without requiring additional OpenSSL libraries or dependencies.
Note: This change is currently untested as I do not have access to the CI environment.