This repository has been archived by the owner on Feb 1, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 14
Blob serialization 6 #73
Merged
jamesray1
merged 9 commits into
Drops-of-Diamond:develop
from
jamesray1:blob-serialization-6
May 21, 2018
Merged
Blob serialization 6 #73
jamesray1
merged 9 commits into
Drops-of-Diamond:develop
from
jamesray1:blob-serialization-6
May 21, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rgo test and cargo build to pass. Failed to run custom build command for node, process didn't exit successfully.
…and all tests passing. Plus minor changes e.g. to build.rs, and adding crate-wide allow guards.
Closing this because it should be better to review this as a PR to blob-serialization-v-5. |
This was referenced May 16, 2018
…sample_collation_body().
|
I did request a review for #67 and #73, https://gitter.im/Drops-of-Diamond/Development?at=5affd1dad245fe2eb7c1b6c8. Although those changes were introduced today while I was fixing up #73. Given the lack of a response I thought nobody was interested; perhaps I should've given more time.
My mistake, fixed that with #77. Merged #76. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add serialization for blobs into collation bodies, with 2 new tests, and all tests passing. Plus minor changes e.g. to build.rs (refactoring all of
main()
tomake_uml_diagram()
, and adding crate-wide allow guards to minimize lots of warnings (allow I have been handling some, and more could be). Plus has changes from #67. We can merge #67 first, then this after rebasing on top of the new develop branch (after merging #67) (which will then be easier to review).The UML diagram generated from
cargo make uml-default-recommended
via the terminal doesn't show a Body struct box with a chunks field. The diagram also doesn't display in the browser when generated fromcargo make docs
.