Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/new folder icons #5

Closed
wants to merge 6 commits into from
Closed

Feature/new folder icons #5

wants to merge 6 commits into from

Conversation

Drucial
Copy link
Owner

@Drucial Drucial commented May 27, 2024

New Folder Icons and Update Icon Script with PyObjC

Description

This pull request introduces new folder icons and updates the icon-setting script to utilize PyObjC for setting folder icons directly in macOS. This enhancement ensures more reliable and efficient handling of custom folder icons within the project.

Key Changes

Folder Icons

  • Added new dark and light folder icons to the project.
  • Deleted old folder icons that are no longer in use.

Script Update

  • Updated set_folder_icon.sh to use AppleScript for setting folder icons.
  • Replaced the shell script invocation with a PyObjC-based implementation in set_folder_icon.py.

Organizer Update

  • Updated organizer.py to set custom folder icons for newly organized directories.

Testing Coverage

Functional Tests

  • Verified that the new folder icons are correctly added and displayed.
  • Ensured that the set_folder_icon.py script correctly sets the folder icons using PyObjC.
  • Confirmed that the organizer.py script correctly creates directories and sets their icons.

How to Test

Run Tests

  1. Install dependencies:

```bash
pip install -r requirements.txt
```

  1. Run the organizer script:

```bash
python src/organizer.py
```

  1. Check that the folder icon is correctly set for the specified directory.

Expected Output

  • The specified directory should display the new custom folder icon.
  • The logs should indicate successful creation of directories and setting of folder icons.

Screenshots:

Not applicable.

Related Issues:

No related issues.

Checklist:

  • Documentation has been updated (if applicable)
  • Tests have been added or updated (if applicable)
  • All new and existing tests pass

Conclusion:

This pull request improves the handling of custom folder icons in the project by utilizing PyObjC, ensuring a more robust and reliable implementation. The addition of new folder icons enhances the visual aspect of the project directories.

@Drucial Drucial closed this May 29, 2024
@Drucial Drucial deleted the feature/new-folder-icons branch May 29, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant