Skip to content

Commit

Permalink
Don't show keymap @error for hints (JuliaLang#56041)
Browse files Browse the repository at this point in the history
It's too disruptive to show errors for hints. The error will still be
shown if tab is pressed.

Helps issues like JuliaLang#56037
  • Loading branch information
IanButterworth authored and Drvi committed Oct 9, 2024
1 parent 0af0124 commit b920069
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion stdlib/REPL/src/LineEdit.jl
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,13 @@ function check_for_hint(s::MIState)
# Requires making space for them earlier in refresh_multi_line
return clear_hint(st)
end
completions, partial, should_complete = complete_line(st.p.complete, st, s.active_module; hint = true)::Tuple{Vector{String},String,Bool}

completions, partial, should_complete = try
complete_line(st.p.complete, st, s.active_module; hint = true)::Tuple{Vector{String},String,Bool}
catch
@debug "error completing line for hint" exception=current_exceptions()
return clear_hint(st)
end
isempty(completions) && return clear_hint(st)
# Don't complete for single chars, given e.g. `x` completes to `xor`
if length(partial) > 1 && should_complete
Expand Down

0 comments on commit b920069

Please sign in to comment.