Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #538 "Bookings for styrelserummet should show a warning" #586

Merged

Conversation

RufusKoggRojder
Copy link
Contributor

Fixed #538 by adding a warning when booking the council room.

Copy link
Contributor

@danieladugyan danieladugyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my minor comment it looks good! 🌟

src/routes/(app)/booking/BookingEditor.svelte Outdated Show resolved Hide resolved
@alfredgrip
Copy link
Contributor

I took the freedom to change "council" to "board", since this is how we usually translate it. We use "council" when refering to "råd" (such as "studierådet" and "trivselrådet"). Revert it if you object 😇

Copy link
Contributor

@danieladugyan danieladugyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix - LGTM!

@RufusKoggRojder RufusKoggRojder merged commit ae82ad7 into Dsek-LTH:main Nov 20, 2024
1 check passed
@RufusKoggRojder RufusKoggRojder deleted the 538-styrelserumm-warning branch November 20, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bookings for styrelserummet should show a warning
3 participants