Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Meilisearch endpoint #611

Merged
merged 12 commits into from
Dec 6, 2024
Merged

Add Meilisearch endpoint #611

merged 12 commits into from
Dec 6, 2024

Conversation

alfredgrip
Copy link
Contributor

@alfredgrip alfredgrip commented Nov 26, 2024

This pull request introduces the integration of Meilisearch into the project to enhance search capabilities. The main changes include setting up Meilisearch, configuring the environment, and implementing search-related functionality.

Environment and Configuration:

  • .env: Added Meilisearch configuration variables MEILISEARCH_HOST and MEILISEARCH_MASTER_KEY.
  • docker-compose.yml: Added a Meilisearch service configuration.
  • dev/setup_db.sh: Updated the script to use docker compose instead of docker run for setting up the database.

Documentation:

Dependency Management:

Search Functionality:

Verified

This commit was signed with the committer’s verified signature.
alfredgrip Alfred Grip

Verified

This commit was signed with the committer’s verified signature.
alfredgrip Alfred Grip
Copy link
Contributor

@danieladugyan danieladugyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nitpicks but it looks awesome!

src/hooks.server.ts Outdated Show resolved Hide resolved
src/routes/(app)/api/search/+server.ts Show resolved Hide resolved
src/routes/(app)/api/search/sync/+server.ts Outdated Show resolved Hide resolved
src/routes/(app)/api/search/sync/+server.ts Outdated Show resolved Hide resolved
src/routes/(app)/api/search/sync/+server.ts Outdated Show resolved Hide resolved
src/routes/(app)/api/search/sync/+server.ts Outdated Show resolved Hide resolved
src/routes/(app)/api/search/meilisearch.ts Outdated Show resolved Hide resolved
@danieladugyan
Copy link
Contributor

danieladugyan commented Nov 27, 2024

It would also be nice to add some brief documentation to docs/reference/external-systems.md.

Verified

This commit was signed with the committer’s verified signature.
alfredgrip Alfred Grip

Verified

This commit was signed with the committer’s verified signature.
alfredgrip Alfred Grip

Verified

This commit was signed with the committer’s verified signature.
alfredgrip Alfred Grip

Verified

This commit was signed with the committer’s verified signature.
alfredgrip Alfred Grip

Verified

This commit was signed with the committer’s verified signature.
alfredgrip Alfred Grip
alfredgrip and others added 5 commits December 3, 2024 19:50

Verified

This commit was signed with the committer’s verified signature.
alfredgrip Alfred Grip

Verified

This commit was signed with the committer’s verified signature.
alfredgrip Alfred Grip

Verified

This commit was signed with the committer’s verified signature.
alfredgrip Alfred Grip
@klaratjernstrom
Copy link

LGTM!

@alfredgrip alfredgrip merged commit 51738b8 into main Dec 6, 2024
2 checks passed
@alfredgrip alfredgrip deleted the search branch December 6, 2024 13:16
@alfredgrip alfredgrip mentioned this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants