Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate smartmatch handling #117

Merged
merged 4 commits into from
Dec 28, 2023
Merged

Deprecate smartmatch handling #117

merged 4 commits into from
Dec 28, 2023

Conversation

haarg
Copy link
Member

@haarg haarg commented Feb 28, 2023

No description provided.

This was referenced Feb 28, 2023
Merged
Closed
demerphq
demerphq approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@demerphq demerphq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes test for me, but i would change the reference to Perl 5.42.0 to be say "by" and not "in", we won't remove support for smartmatch exactly in 5.42.0 it will be sometime in 5.41.x in practice.

lib/Fatal.pm Outdated Show resolved Hide resolved
@toddr
Copy link
Collaborator

toddr commented Mar 6, 2023

I'll await consensus on the plan before I merge and publish this. @haarg @demerphq. Please let me know.

leonerd
leonerd reviewed Mar 6, 2023
View reviewed changes
lib/Fatal.pm Show resolved Hide resolved
@haarg haarg force-pushed the deprecate-smartmatch branch 2 times, most recently from 36945fa to 5d2a002 Compare March 8, 2023 14:39
@haarg
deprecate smart matching for hints, but silence warnings
f56e3fb 
New versions of perl are deprecating smart match, and they should
eventually be removed. Update the code to silence the warnings related
to smart match to properly disable "deprecated" warnings internally.

Add our own deprecation warnings on all versions of perl that support
smartmatch.

Stop supporting smart match in perl 5.41.
@toddr
Copy link
Collaborator

toddr commented Mar 9, 2023 •
edited
Loading

Looks like we've closed one perl PR and opened Perl/perl5#20916. I'm not clear how this changes this PR. @demerphq

@haarg
Copy link
Member Author

haarg commented Mar 9, 2023

If that PR was merged, this could be changed to use a different warning category, but the current code in this PR would continue to work without changes. I don't think it needs to be considered when evaluating this PR.

@toddr
Copy link
Collaborator

toddr commented Mar 9, 2023

ok waiting on someone's OK to merge this.

@demerphq
Copy link
Contributor

@toddr i am not sure who you are waiting for, but if it helps "LGTM".

I closed my original ticket about the deprecation categories because I agree with @haarg that this PR stands alone just fine. I think we should have deprecation categories, but for other reasons than to use as switches for behavior. More because it provides a better user experience and allows the user to micro-manage their exposure to features that are deprecated.

@toddr toddr merged commit ec608fe into Dual-Life:master Dec 28, 2023
toddr added a commit that referenced this pull request Dec 28, 2023
@toddr
v2.37
718a1b9 
	* #117 - Deprecate smartmatch handling

	* #118 - Remove mention of cpanratings.perl.org

	* #119 - Fix typo in changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@demerphq demerphq demerphq approved these changes

@leonerd leonerd leonerd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@haarg @toddr @demerphq @leonerd