Keep previous refresh token if not updated during refresh #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…freshToken, retrieve the previous one
josephdecock
requested changes
Nov 28, 2023
There was a problem hiding this comment.
IdentityServer always returns the refresh token (either the existing one or a new one if we rotated). But, the spec says that this is optional, so I think this is probably a fine change to make. I would like to see a test of this added though.
(H) The authorization server authenticates the client and validates the refresh token, and if valid, issues a new access token (and, optionally, a new refresh token).
|
@hybrid2102 Are you able to add such a test? |
I sincerely apologize for the delay and for my current inability to add such a test. 🙇♂️ |
Test confirms that when we get a refresh token response without a refresh token in it, we continue to use the old refresh token.
josephdecock
approved these changes
May 2, 2024
josephdecock
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this PR address?
After refreshing the AccessToken, the response may not contain a new RefreshToken (maybe because the previous one is not expired).
With this commit, the previous RefreshToken will be provided instead of a null value.
Important: Any code or remarks in your Pull Request are under the following terms:
If You provide us with any comments, bug reports, feedback, enhancements, or modifications proposed or suggested by You for the Software, such Feedback is provided on a non-confidential basis (notwithstanding any notice to the contrary You may include in any accompanying communication), and Licensor shall have the right to use such Feedback at its discretion, including, but not limited to the incorporation of such suggested changes into the Software. You hereby grant Licensor a perpetual, irrevocable, transferable, sublicensable, nonexclusive license under all rights necessary to incorporate and use your Feedback for any purpose, including to make and sell any products and services.
(see our license, section 7)