Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use example.com subdomains instead of "real" domain names #209

Closed
wenz opened this issue Sep 18, 2024 · 3 comments · Fixed by #210
Closed

Use example.com subdomains instead of "real" domain names #209

wenz opened this issue Sep 18, 2024 · 3 comments · Fixed by #210

Comments

@wenz
Copy link
Contributor

wenz commented Sep 18, 2024

The samples are referring to "real" domain names such as alice.com, bob.com, and email.com. I would propose to change that to, say, alice.example.com, bob.example.com, and email.example.com to make crystal-clear that these really are examples. Just imagine one of those domains (especially the first two) gets cybersquatted.

@wenz
Copy link
Contributor Author

wenz commented Sep 18, 2024

If that change is desired, I'd create PRs for other repositories with those domain names, as well. If not, no worries. :)

@leastprivilege
Copy link
Member

Thanks!

@wenz
Copy link
Contributor Author

wenz commented Sep 18, 2024

Hm, maybe we should actually use example.com instead of email.example.com (which doesn't make sense). I'll update the PR accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants