Remove unneeded and confusing DPoP code #220
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephdecock
reviewed
Dec 6, 2024
Comment on lines
-15
to
-19
| // this shows how you can prevent DPoP from being used at an API endpoint | ||
| // and this will cause the request to send the same token with the Bearer scheme | ||
| //return Task.FromResult<DPoPProof>(null); | ||
| } | ||
| return base.CreateProofTokenAsync(request); |
There was a problem hiding this comment.
I think this is, while perhaps unusual, a valid use case. Maybe we need to follow this idea all the way through to the end, but I don't really want to just toss this. Are users confused?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.