Skip to content

Commit

Permalink
Revert nullable annotation in OidcReturnUrlParser
Browse files Browse the repository at this point in the history
Intent is to add nullable annotations to interfaces and extension points,
but not internal implementations
  • Loading branch information
josephdecock committed Jul 7, 2023
1 parent 70392b3 commit 4f050e1
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions src/IdentityServer/Services/Default/OidcReturnUrlParser.cs
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Copyright (c) Duende Software. All rights reserved.
// See LICENSE in the project root for license information.

#nullable enable

using System;
using System.Threading.Tasks;
using Duende.IdentityServer.Extensions;
Expand All @@ -23,15 +21,15 @@ internal class OidcReturnUrlParser : IReturnUrlParser
private readonly IUserSession _userSession;
private readonly IServerUrls _urls;
private readonly ILogger _logger;
private readonly IAuthorizationParametersMessageStore? _authorizationParametersMessageStore;
private readonly IAuthorizationParametersMessageStore _authorizationParametersMessageStore;

public OidcReturnUrlParser(
IdentityServerOptions options,
IAuthorizeRequestValidator validator,
IUserSession userSession,
IServerUrls urls,
ILogger<OidcReturnUrlParser> logger,
IAuthorizationParametersMessageStore? authorizationParametersMessageStore = null)
IAuthorizationParametersMessageStore authorizationParametersMessageStore = null)
{
_options = options;
_validator = validator;
Expand All @@ -41,7 +39,7 @@ public OidcReturnUrlParser(
_authorizationParametersMessageStore = authorizationParametersMessageStore;
}

public async Task<AuthorizationRequest?> ParseAsync(string returnUrl)
public async Task<AuthorizationRequest> ParseAsync(string returnUrl)
{
using var activity = Tracing.ValidationActivitySource.StartActivity("OidcReturnUrlParser.Parse");

Expand Down

0 comments on commit 4f050e1

Please sign in to comment.