Skip to content

Add null-check for client before coordinating session lifecycle#2038

Merged
khalidabuhakmeh merged 2 commits intoreleases/is/7.2.xfrom
ka-dscs-fix-7.2
Jun 4, 2025
Merged

Add null-check for client before coordinating session lifecycle#2038
khalidabuhakmeh merged 2 commits intoreleases/is/7.2.xfrom
ka-dscs-fix-7.2

Conversation

@khalidabuhakmeh
Copy link
Contributor

Make sure to do a null check on client in ProcessExpirationAsync to stop possible null reference exceptions when the client is not found.

Ensure that the client object is not null before attempting to determine its session coordination behavior.
…ation

Ensure `DefaultSessionCoordinationService` does not attempt logout for missing or null clients by introducing a dedicated test.
bhazen
bhazen previously approved these changes Jun 4, 2025
@bhazen bhazen dismissed their stale review June 4, 2025 16:42

Missed there was a failing test

@khalidabuhakmeh khalidabuhakmeh merged commit dcf95c0 into releases/is/7.2.x Jun 4, 2025
3 of 4 checks passed
@khalidabuhakmeh khalidabuhakmeh deleted the ka-dscs-fix-7.2 branch June 4, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/products/is IdentityServer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants