Suppress M261.1 Modbus comm error when V passed
#1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dc42
requested changes
Aug 21, 2024
benagricola
force-pushed
the
3.6-dev
branch
3 times, most recently
from
318db3a
to
0ccba92
Compare
|
Whoops, capitalisation error in the previous commit ( |
Signed-off-by: Ben Agricola <ben+git@agrico.la>
|
@dc42 Anything else that needs doing to get this merged? Modbus error reporting is problematic if you're calling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick overview on the forum - but in short, it is already possible to check the status of the Modbus request by checking that the value of the variable is not
null.The error message output by
M261.1on Modbus communication failure is unnecessary for reads where thenullresult ends up in a variable anyway, and just ends up spamming the console when using the command programmatically.